Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS -- add function eMailValidate used to validate an email address #12719

Merged
merged 1 commit into from
Dec 10, 2020
Merged

JS -- add function eMailValidate used to validate an email address #12719

merged 1 commit into from
Dec 10, 2020

Conversation

calixteman
Copy link
Contributor

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e0c23bd0151fae4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/9edbaf832339dd2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/e0c23bd0151fae4/output.txt

Total script time: 25.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/e0c23bd0151fae4/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/9edbaf832339dd2/output.txt

Total script time: 30.36 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/9edbaf832339dd2/reftest-analyzer.html#web=eq.log

timvandermeij
timvandermeij reviewed Dec 10, 2020
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with these comments addressed.

src/scripting_api/aform.js Outdated Show resolved Hide resolved
src/scripting_api/aform.js Outdated Show resolved Hide resolved
test/unit/scripting_spec.js Outdated Show resolved Hide resolved
src/scripting_api/aform.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b814532c120a4f4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 1

Live output at: http://3.101.106.178:8877/32ac2324d6bfcca/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/b814532c120a4f4/output.txt

Total script time: 3.69 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/32ac2324d6bfcca/output.txt

Total script time: 4.63 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 954ac3d into mozilla:master Dec 10, 2020
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @pdfjsbot @timvandermeij