-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form printing support #12076
Closed
Closed
Add form printing support #12076
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5f61c6e
Add form printing support
calixteman 13f7dff
Add form printing support for Firefox
calixteman e8542dc
Address nits
calixteman 541ad5f
Forgot to disable renderInteractiveForms
calixteman 8ef0492
Default text rise is now based on font.descent
calixteman c6a4c1e
Handle multiline text
calixteman ce18017
Don't export EvalState
calixteman 64f6e17
Export EvalState and use it to get font
calixteman 020ffd0
Font descent can be NaN
calixteman e7e11dc
By default a textfield is left aligned
calixteman f13252a
Handle auto-sized font in textfields
calixteman 2d11d4c
Don't leak password if any
calixteman 3fe52eb
Fix tests after default text alignment change
calixteman a8c553f
Handle choice widget
calixteman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note the default value in
pdf.js/src/core/evaluator.js
Lines 1224 to 1235 in 72d71ba
initialState
here (nor exportEvalState
in the other file).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed EvalState export but I want to pass an initialState to be able to get the font and the font size from it in order to compute text width (and split it for multiline textfields).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to chat about that or anything else, then I'm on riot in the pdf.js channel, my nick is "calixte" (in CEST timezone).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I completely overlooked that you actually accessed the state afterwards; in that case exporting/using it like you previously did is probably OK.
(Although it does feel slightly "hacky" to do things in that way, given how the
getOperatorList
method in currently implemented/used, however at the top of my head I don't really have a much better suggestion.)