Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Fix the return value of PDFDocumentProxy.getViewerPreferences when no viewer preferences are present (PR 10738 follow-up) #11806

Merged
merged 1 commit into from
Apr 15, 2020

Commits on Apr 14, 2020

  1. [api-minor] Fix the return value of `PDFDocumentProxy.getViewerPrefer…

    …ences` when no viewer preferences are present (PR 10738 follow-up)
    
    This patch fixes yet another instalment in the never-ending series of "what the *bleep* was I thinking", by changing the `PDFDocumentProxy.getViewerPreferences` method to return `null` by default.
    Not only is this method now consistent with many other API methods, for the data not present case, but it also avoids having to e.g. loop through an object to check if it's actually empty (note the old unit-test).
    Snuffleupagus committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    746eaf3 View commit details
    Browse the repository at this point in the history