Ensure that ReadableStreams are cancelled with actual Errors
#11034
Conversation
There's a number of spots in the current code, and tests, where `cancel` methods are not called with appropriate arguments (leading to Promises not being rejected with Errors as intended). In some cases the cancel `reason` is implicitly set to `undefined`, and in others the cancel `reason` is just a plain String. To address this inconsistency, the patch changes things such that cancelling is done with `AbortException`s everywhere instead.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9928837f7fb80e1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8f1c941f2a9ca23/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8f1c941f2a9ca23/output.txt Total script time: 2.63 mins
|
|
Check that the Linux failure is still intermittent... /botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6992ef929fe3af9/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9928837f7fb80e1/output.txt Total script time: 5.36 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6992ef929fe3af9/output.txt Total script time: 2.60 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ba05b3bdea87487/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ba05b3bdea87487/output.txt Total script time: 1.72 mins Published |
|
Thanks! |
There's a number of spots in the current code, and tests, where
cancelmethods are not called with appropriate arguments (leading to Promises not being rejected with Errors as intended).In some cases the cancel
reasonis implicitly set toundefined, and in others the cancelreasonis just a plain String. To address this inconsistency, the patch changes things such that cancelling is done withAbortExceptions everywhere instead.