Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a superfluous linkService.isPageVisible check from PDFFindController (PR 10217 follow-up) #10897

Merged
merged 1 commit into from
Jun 11, 2019

Commits on Jun 10, 2019

  1. Remove a superfluous linkService.isPageVisible check from `PDFFindC…

    …ontroller` (PR 10217 follow-up)
    
    Unless the `PDFLinkService` instance contains all of the expected methods, a lot of things will break in various places in the default viewer. Hence there's not much value in having this check, and outright falling seems more appropriate.
    
    Finally, this also makes the return value explicit in this case, since that's consistent with the rest of the `PDFFindController._shouldDirtyMatch` method.
    Snuffleupagus committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    d6cc393 View commit details
    Browse the repository at this point in the history