Ignore the fieldValue for Signature annotations, since they're currently unsupported (issue 10374)
#10350
Conversation
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8d544ab9de66711/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/366f757c250c040/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8d544ab9de66711/output.txt Total script time: 0.76 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/366f757c250c040/output.txt Total script time: 2.26 mins
|
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e91e3b81e8644aa/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e66b293ecd1d279/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e91e3b81e8644aa/output.txt Total script time: 2.80 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e66b293ecd1d279/output.txt Total script time: 5.25 mins
|
…ently unsupported (issue 10374) Given that Signature (Widget) annotations are currently not supported, since they cannot be validated, simply ignoring the `fieldValue` seems OK for now considering that attempting to blindly include unparsed/unvalidated data isn't very useful. Fixes 10347.
Snuffleupagus
force-pushed
the
sig-fieldValue-null
branch
from
c5627e3
to
437fb8a
Compare
Snuffleupagus
changed the title
fieldValue for Signature annotations, since there're currently unsupported (issue 10374)fieldValue for Signature annotations, since they're currently unsupported (issue 10374)
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9d8adf6ece45d9d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/ca40e30c6152107/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9d8adf6ece45d9d/output.txt Total script time: 0.76 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ca40e30c6152107/output.txt Total script time: 2.19 mins
|
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f1b734fa8f50cf2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8281a55fa0759cd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8281a55fa0759cd/output.txt Total script time: 2.88 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f1b734fa8f50cf2/output.txt Total script time: 4.96 mins
|
|
I think this is fine too. Thank you for fixing this! |
Given that Signature (Widget) annotations are currently not supported, since they cannot be validated, simply ignoring the
fieldValueseems OK for now considering that attempting to blindly include unparsed/unvalidated data isn't very useful.Fixes #10347.