Update packages and translations #10170
Conversation
|
/botio-windows preview |
timvandermeij
force-pushed
the
updates
branch
from
9c03867
to
9b63b3e
Compare
|
/botio-linux preview |
timvandermeij
force-pushed
the
updates
branch
from
9b63b3e
to
45969f3
Compare
|
/botio-linux preview |
|
/botio preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/949a40a3f6e111c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/74d5b24449b22ef/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/949a40a3f6e111c/output.txt Total script time: 2.97 mins Published |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/74d5b24449b22ef/output.txt Total script time: 4.35 mins Published |
|
What? I even removed the commit about updating packages and the preview still fails, but it works locally. |
|
Most likely the problems are caused by the new Webpack version, since comparing the output of --- \master\build\pdf.js
+++ \patch\build\pdf.js
@@ -7794,7 +7794,7 @@
require.ensure = require('node-ensure');
}
useRequireEnsure = true;
- } else if (typeof require !== 'undefined' && typeof require.ensure === 'function') {
+ } else if (true && typeof require.ensure === 'function') {
useRequireEnsure = true;
}
if (typeof requirejs !== 'undefined' && requirejs.toUrl) {Either there's a regression in the new Webpack version, see the release info at https://github.com/webpack/webpack/releases, and/or there's something wrong with the bundle definitions in our |
Webpack is pinned because versions higher than this cause the viewer not to work (see mozilla#10170 (comment)).
Webpack is pinned because versions higher than this cause the viewer not to work (see mozilla#10170 (comment)).
Webpack is pinned because versions higher than this cause the viewer not to work (see mozilla#10170 (comment)). Node.js is pinned for Travis CI because version 11 requires that we update to Gulp 4.
|
How about updating to 4.21.0 first to narrow down which version has caused the issue? |
|
In the end (in another pull request) I did that (see https://github.com/mozilla/pdf.js/blob/master/package.json#L40) and 4.21.0 was the last one that didn't have the issue. I created #10177 to follow up on this. |
No description provided.