-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gulp
to version 5.0.0
#17922
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Without some However, it seems that others have run into similar/same problems and according to gulpjs/gulp#2802 (comment) there's an "official" gulp-helper available; see https://www.npmjs.com/package/ordered-read-streams |
…reams` dependency The `merge-stream` dependency is no longer maintained and doesn't work in combination with Gulp 5 anymore (for more information refer to gulpjs/gulp#2802 (comment)). Fortunately the Gulp team maintains a drop-in replacement dependency called `ordered-read-streams` with the same API as `merge-stream`. Indeed, running all affected Gulp targets and comparing build artifacts with `diff -r <old> <new>` confirms that no unexpected changes are made. Fixes a part of mozilla#17922.
Nice find; thanks! I have made the PR above to replace |
We should upgrade to Gulp 5 now that it's officially released. The changelog, including the breaking changes that mostly don't seem to affect us, can be found at https://github.com/gulpjs/gulp/releases/tag/v5.0.0.
I have already quickly tried the upgrade locally to see if it would be easy or not, and found that the main blocker appears to be the
merge-stream
package. It doesn't seem to work anymore with Gulp 5, causing tracebacks for most tasks (because of most of them directly or indirectly rely onmerge
calls).The last commit for
merge-stream
, see https://github.com/grncdr/merge-stream, was 5 years ago, so this probably isn't very surprising. However, I played around with removing themerge
calls altogether and didn't immediately find something that was obviously broken, so I'm mainly wondering what the use case of it is or was at the time of introduction (maybe it's obsolete nowadays, or something breaks when removing it that I just haven't noticed yet...). Sadly I haven't been able to find out more from e.g. Git commit messages.We should investigate if
merge-stream
can be fixed, replaced or removed. Once that is addressed Gulp 5 should work, but note that we still need to carefully test all commands.The text was updated successfully, but these errors were encountered: