-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the various colors in web/viewer.css
to CSS variables
#11572
Comments
Before we start converting everything but the kitchen sink to use CSS variables, we may want to avoid adding "too many" until the performance impact (in Firefox) of doing so is better understood; based on stumbling upon https://groups.google.com/d/msg/firefox-dev/wQKKyH4vXks/iFmRdHBcEwAJ and https://bugzilla.mozilla.org/show_bug.cgi?id=1561001#c4 yesterday. Edit: I obviously don't know exactly how many is too many, but we probably want to avoid adding hundreds of CSS variables. |
Would like to work on this! |
As already mentioned in #11572 (comment), this would be best done as part of other CSS modernization/improvement work:
|
@Snuffleupagus Got it! |
I am new to mozilla. Can I work on this? |
Fixed by #11077. |
To make re-skinning the viewer easier, the various repeated colors in
web/viewer.css
should be converted to CSS variables. This way they should be easier to tweak for third-party deployments of PDF.js.The text was updated successfully, but these errors were encountered: