Skip to content

Commit

Permalink
Merge pull request #17267 from Snuffleupagus/lint-workflow
Browse files Browse the repository at this point in the history
Move linting to a separate GitHub Actions workflow
  • Loading branch information
timvandermeij authored Nov 12, 2023
2 parents 9172d64 + 2f70369 commit e0e5be2
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 5 deletions.
37 changes: 37 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Lint
on: [push, pull_request]
permissions:
contents: read

jobs:
lint:
name: Lint
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
node-version: [lts/*]

steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Install Gulp
run: npm install -g gulp-cli

- name: Install other dependencies
run: npm install

- name: Run lint
run: gulp lint

- name: Run lint-chromium
run: gulp lint-chromium
6 changes: 1 addition & 5 deletions gulpfile.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2439,9 +2439,5 @@ gulp.task("externaltest", function (done) {

gulp.task(
"ci-test",
gulp.series(
gulp.parallel("lint", "externaltest", "unittestcli"),
"lint-chromium",
"typestest"
)
gulp.series(gulp.parallel("externaltest", "unittestcli"), "typestest")
);

0 comments on commit e0e5be2

Please sign in to comment.