Merge pull request #16495 from Snuffleupagus/PDFRenderingQueue-compon…

…ents Limit some `PDFRenderingQueue`-related code to the GENERIC viewer
mozilla · Jun 3, 2023 · bb5d38a · bb5d38a
2 parents 63b61ca + e8c7277
commit bb5d38a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/web/pdf_rendering_queue.js b/web/pdf_rendering_queue.js
@@ -36,6 +36,12 @@ class PDFRenderingQueue {
     this.idleTimeout = null;
     this.printing = false;
     this.isThumbnailViewEnabled = false;
+
+    if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
+      Object.defineProperty(this, "hasViewer", {
+        value: () => !!this.pdfViewer,
+      });
+    }
   }
 
   /**
@@ -60,13 +66,6 @@ class PDFRenderingQueue {
     return this.highestPriorityPage === view.renderingId;
   }
 
-  /**
-   * @returns {boolean}
-   */
-  hasViewer() {
-    return !!this.pdfViewer;
-  }
-
   /**
    * @param {Object} currentlyVisiblePages
    */

diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js
@@ -301,7 +301,10 @@ class PDFViewer {
     }
 
     this.defaultRenderingQueue = !options.renderingQueue;
-    if (this.defaultRenderingQueue) {
+    if (
+      (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) &&
+      this.defaultRenderingQueue
+    ) {
       // Custom rendering queue is not specified, using default one
       this.renderingQueue = new PDFRenderingQueue();
       this.renderingQueue.setViewer(this);