Merge pull request #15925 from Snuffleupagus/update-rimraf

Update `rimraf` to version 4

gulpfile.js

@@ -26,7 +26,7 @@ const rename = require("gulp-rename");
 const replace = require("gulp-replace");
 const mkdirp = require("mkdirp");
 const path = require("path");
-const rimraf = require("rimraf");
+const { rimraf } = require("rimraf");
 const stream = require("stream");
 const exec = require("child_process").exec;
 const spawn = require("child_process").spawn;
@@ -1461,22 +1461,19 @@ gulp.task(
   )
 );
 
-gulp.task("jsdoc", function (done) {
+gulp.task("jsdoc", async function (done) {
   console.log();
   console.log("### Generating documentation (JSDoc)");
 
   const JSDOC_FILES = ["src/display/api.js"];
 
-  rimraf(JSDOC_BUILD_DIR, function () {
-    mkdirp(JSDOC_BUILD_DIR).then(function () {
-      const command =
-        '"node_modules/.bin/jsdoc" -d ' +
-        JSDOC_BUILD_DIR +
-        " " +
-        JSDOC_FILES.join(" ");
-      exec(command, done);
-    });
-  });
+  await rimraf(JSDOC_BUILD_DIR);
+  await mkdirp(JSDOC_BUILD_DIR);
+
+  const command = `"node_modules/.bin/jsdoc" -d ${JSDOC_BUILD_DIR} ${JSDOC_FILES.join(
+    " "
+  )}`;
+  exec(command, done);
 });
 
 gulp.task("types", function (done) {
@@ -2083,11 +2080,12 @@ gulp.task(
   )
 );
 
-gulp.task("clean", function (done) {
+gulp.task("clean", async function (done) {
   console.log();
   console.log("### Cleaning up project builds");
 
-  rimraf(BUILD_DIR, done);
+  await rimraf(BUILD_DIR);
+  done();
 });
 
 gulp.task("importl10n", function (done) {
@@ -2254,7 +2252,7 @@ gulp.task(
 
       console.log();
       console.log("### Overwriting all files");
-      rimraf.sync(path.join(DIST_DIR, "*"));
+      rimraf.sync(DIST_DIR);
 
       return merge([
         packageJson().pipe(gulp.dest(DIST_DIR)),
@@ -2446,7 +2444,7 @@ gulp.task(
       // The mozcentral baseline directory is a Git repository, so we
       // remove all files and copy the current mozcentral build files
       // into it to create the diff.
-      rimraf.sync(MOZCENTRAL_BASELINE_DIR + "*");
+      rimraf.sync(MOZCENTRAL_BASELINE_DIR);
 
       gulp
         .src([BUILD_DIR + "mozcentral/**/*"])