Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"about:" pages can be added to FBC, the titles are displayed as empty in the list and they can't be removed #588

Closed
gpalko-SV opened this issue Feb 17, 2020 · 2 comments
Labels
has PR Pull request already submitted.

Comments

@gpalko-SV
Copy link

  • Facebook Container Version: 2.1.0
  • Affected platforms:
    - Windows 10 x64
    - MacOS 10.15
    - Ubuntu 18.04

Steps to reproduce

  1. Add Facebook Container 2.1.0 to Firefox
  2. Open any about: page in new tab (e.g about:support)
  3. Allow the page in FBC
  4. Click the Facebook Container icon and select "Sites Allowed in Facebook Container"

Actual behavior

  1. The page is added to list but the page title is displayed as empty
  2. The page remains in the list after removing it from FBC
  3. A new entry containing the add-on UUID is added to list after every Remove attempt

Expected behavior

  1. The page titles should be displayed in the Allowed list
  2. The about: pages should be removable from FBC
  3. No new items should appear in the allowed list after remove operation

OR

The user should not be able to add "about:" pages to FBC

Notes

See the attached screenshot
aboutPageAdded

@maxxcrawford
Copy link
Collaborator

IMO I don’t think about: pages should be allowed inside the container. I recommend we handle them in the same way removing default Facebook domains (Facebook.com, Instagram.com, etc.) is not allowed.

image

@maxxcrawford maxxcrawford added the has PR Pull request already submitted. label Feb 17, 2020
groovecoder added a commit that referenced this issue Feb 17, 2020
Fixed #588 - Added logic to stop about: pages from being added to the container
@gpalko-SV
Copy link
Author

Verified on build 2.1.0-rc2, that about: pages cannot be added to FBC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR Pull request already submitted.
Projects
None yet
Development

No branches or pull requests

2 participants