Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn amo no longer works - no styles/JS #12793

Closed
kumar303 opened this issue Dec 11, 2018 · 4 comments · Fixed by mozilla/addons-frontend#9956
Closed

yarn amo no longer works - no styles/JS #12793

kumar303 opened this issue Dec 11, 2018 · 4 comments · Fixed by mozilla/addons-frontend#9956
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.
Milestone

Comments

@kumar303
Copy link
Contributor

Describe the problem and steps to reproduce it:

  • Go into addons-server and start up the container with docker-compose up -d
  • Go back to addons-frontend and run yarn amo to develop with a local Docker image. This is documented as the preferred way to start a server yet no one uses it in practice.

What happened?

The server starts but no styles or JS loads so the app is not usable.

What did you expect to happen?

The site should be usable.

Anything else we should know?

I think the culprit might be related to how the addons-server Docker container boots its own frontend instance on the same port as what addons-frontend uses. There is an additional problem where the addons-frontend startup script does not report a failure about how it cannot bind to the port.

@b4handjr
Copy link

We could move that to the docker-compose.selenium.yml file. That config is mainly used for testing anyways.

@kumar303
Copy link
Contributor Author

That sounds like it would solve it

@EnTeQuAk
Copy link
Contributor

addons-server now actually defaults to the new frontend by default so it's used for development kinda as well. Happy to change configs though to resolve any conflicts we may have.

@stale
Copy link

stale bot commented Jan 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Jan 1, 2020
@stale stale bot closed this as completed Jan 15, 2020
@willdurand willdurand self-assigned this Jan 7, 2021
@willdurand willdurand added this to the 2021.01.14 milestone Jan 7, 2021
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.
Development

Successfully merging a pull request may close this issue.

7 participants