Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addons-frontend image config to seperate docker-compose.yml #6249

Closed
b4handjr opened this issue Dec 11, 2018 · 6 comments
Closed

Move addons-frontend image config to seperate docker-compose.yml #6249

b4handjr opened this issue Dec 11, 2018 · 6 comments
Assignees
Labels
repository:addons-server Issue relating to addons-server

Comments

@b4handjr
Copy link

As seen here, moving the addons-frontend config within the base docker-compose.yml file to the docker-compose.selenium.yml file would fix that issue.

The secondary compose.yml should probably be renamed to docker-compose.ui-tests.yml or something like that.

@EnTeQuAk
Copy link
Contributor

Note that with #5927 there now already is a tests/ui/docker-compose.selenium.yml file.

@b4handjr
Copy link
Author

Yup, what do you think about renaming it?

@EnTeQuAk
Copy link
Contributor

I really don't have a preference, we could even drop the .selenium postfix and just name it docker-compose.yml 🤷‍♂️

@b4handjr
Copy link
Author

Well I think it should have some kinda reference, but okay good to know.

@willdurand
Copy link
Member

See also: #6120

@b4handjr
Copy link
Author

b4handjr commented Jan 2, 2019

@willdurand that was fixed here mozilla/addons-server#10143.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

4 participants