Fix for DS_IntermediateDecode modifying live prefixes in DecoderState

[reuben]

No description provided.

[reuben]

@eggonlea can you try this fix and verify if it fixes the bug you found?

[eggonlea]

Works as expected with different "--stream size".

But copying all prefixes and creating new maps is time consuming. The smaller stream size, the lower efficiency. It would be great if we can avoid the copy at all.

[reuben]

Yes, it is. I'm trying to design a better way of fixing this, the PathTrie makes it a bit tricky.

[reuben]

Although it should only really matter if you call intermediate decode very often.

[reuben]

@lissyx the crux of the problem here is that in decoder_decode we were sorting the live prefixes still being used by decoder_next, which changes the behavior of the decoder over the whole stream. This solution is a bit hacky, it copies the prefix vector, stores the modified scores outside of the vector, and then sorts them with an external score, which keeps all the live prefixes unchanged except for approx_ctc (which isn't used in decoder_next). A better fix requires more substantial changes to the decoder implementation, but I'd rather fix this quickly for 0.5.1.

[lissyx]

r+

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.