Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported symbols should not be C++ mangled #2105

Merged
merged 1 commit into from
May 10, 2019
Merged

Exported symbols should not be C++ mangled #2105

merged 1 commit into from
May 10, 2019

Conversation

lissyx
Copy link
Collaborator

@lissyx lissyx commented May 10, 2019

No description provided.

@lissyx lissyx requested a review from reuben May 10, 2019 10:19
@lissyx lissyx self-assigned this May 10, 2019
reuben
reuben reviewed May 10, 2019
View reviewed changes
Copy link
Contributor

@reuben reuben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be applied to the new structs we have which aren't just opaque pointers?

We should also notify maintainers of bindings.

@lissyx
Copy link
Collaborator Author

lissyx commented May 10, 2019

@est31 @asticode You may want to check if your bindings needs changes :-)

@lissyx lissyx merged commit e491705 into mozilla:master May 10, 2019
@lock
Copy link

lock bot commented Jun 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jun 9, 2019
@lissyx lissyx deleted the export-c branch January 13, 2020 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reuben reuben reuben left review comments

Assignees

@lissyx lissyx

Labels
breaks-bw-compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lissyx @reuben