Add NodeJS v12 support #2073
Merged
Add NodeJS v12 support #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lissyx
force-pushed
the
nodejs-v12
branch
2 times, most recently
from
db85695
to
f9d66fb
Compare
reuben
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
Changes themselves look OK to me. r+ with green tests. I worry about the constant scope increase with new versions of Node/Electron, as well as increased build and test times for PRs, but I guess with the fragmentation in the Node versions there's not much we can do.
added 2 commits
April 25, 2019 15:43
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2070