Build for ElectronJS #2035
Build for ElectronJS #2035
Conversation
lissyx
force-pushed
the
electronjs
branch
3 times, most recently
from
938698b
to
dcc22a7
Compare
|
We can build for a lot of ElectronJS flavors, but I suggest we stick with testing at least linux/macOS/windows on amd64. We can try and add more testing later, depending on people's usecases and feedback. |
lissyx
force-pushed
the
electronjs
branch
10 times, most recently
from
fd1a33f
to
dcee783
Compare
| NODE_RUNTIME=--runtime=electron \ | ||
| clean node-wrapper | ||
| done; | ||
|
|
There was a problem hiding this comment.
Is this roughly doubling the size of the Node package as well as the time to build it? Could we separate Node.JS and Electron packages, or does that not make sense in the Node ecosystem?
There was a problem hiding this comment.
It seems that it does not make sense in the ecosystem, but it's not really doubling, we just add a few deepspeech.node binaries, ranging from 50k to 100k. All docs I found would pull from npmjs for ElectronJS. And build time does increase, but it's marginal, takes < 30 secs for each ElectronJS instance. We would win much more build time by doing the heavy lifting of producing ready-to-use Docker images.
There was a problem hiding this comment.
Understood. My review+ remains :)
lissyx
force-pushed
the
electronjs
branch
11 times, most recently
from
7e9655f
to
145510c
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.