Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add probability to Metadata struct (Fixes #900) #2012

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Add probability to Metadata struct (Fixes #900) #2012

merged 1 commit into from
Apr 8, 2019

Conversation

reuben
Copy link
Contributor

@reuben reuben commented Apr 5, 2019

No description provided.

@reuben reuben requested a review from lissyx April 6, 2019 01:33
lissyx
lissyx approved these changes Apr 6, 2019
View reviewed changes
Copy link
Collaborator

@lissyx lissyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just don't remember what strdup does in the back hence the free question 😁

native_client/deepspeech.cc
delete(m);
for (int i = 0; i < m->num_items; ++i) {
free(m->items[i].character);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why free here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strdup == malloc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kdavis-mozilla
kdavis-mozilla approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@kdavis-mozilla kdavis-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reuben reuben merged commit 89ed0f4 into master Apr 8, 2019
@reuben reuben deleted the output-probability branch April 8, 2019 12:24
@lock
Copy link

lock bot commented May 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lissyx lissyx lissyx approved these changes

@kdavis-mozilla kdavis-mozilla kdavis-mozilla approved these changes

Assignees

@reuben reuben

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reuben @lissyx @kdavis-mozilla