Embed more metadata in exported model and read it in native client #2007
Conversation
| @@ -724,6 +724,17 @@ def do_graph_freeze(output_file=None, output_node_names=None, variables_blacklis | |||
| if not FLAGS.export_tflite: | |||
| frozen_graph = do_graph_freeze(output_node_names=output_names, variables_blacklist='previous_state_c,previous_state_h') | |||
| frozen_graph.version = int(file_relative_read('GRAPH_VERSION').strip()) | |||
|
|
|||
| # Add a no-op node to the graph with metadata information to be loaded by the native client | |||
There was a problem hiding this comment.
And we don't break with TF Lite? nice :)
There was a problem hiding this comment.
Nope. We don't get the info in the TFLite graph either, unfortunately. I'll try to find a workaround when I have some time.
| @@ -73,6 +77,7 @@ def create_flags(): | |||
| tf.app.flags.DEFINE_boolean ('export_tflite', False, 'export a graph ready for TF Lite engine') | |||
| tf.app.flags.DEFINE_boolean ('use_seq_length', True, 'have sequence_length in the exported graph (will make tfcompile unhappy)') | |||
| tf.app.flags.DEFINE_integer ('n_steps', 16, 'how many timesteps to process at once by the export graph, higher values mean more latency') | |||
| tf.app.flags.DEFINE_string ('export_model_language', '', 'language the model was trained on. Gets embedded into exported model.') | |||
There was a problem hiding this comment.
I'd like we get a different naming, it's confusing, I thought it was the language model we were embedding, I ad t ore-read carefully several time. Can the option be named "add_language_metadata" ?
There was a problem hiding this comment.
How about this:
tf.app.flags.DEFINE_string ('export_language', '', 'language the model was trained on e.g. "en" or "English". Gets embedded into exported model.')
|
OSX workers are acting up but the relevant code has been exercised in other completed tests. Merged manually to avoid starting another group here in the PR. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.