Fix invalid characters in speech to text result #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
reuben
reviewed
Jan 30, 2019
| while (Marshal.ReadByte(res, len) != 0) ++len; | ||
| byte[] buffer = new byte[len]; | ||
| Marshal.Copy(res, buffer, 0, buffer.Length); | ||
| return Encoding.UTF8.GetString(buffer); |
There was a problem hiding this comment.
Can these lines instead just be return Marshall.PtrToStringUTF8(res)?
There was a problem hiding this comment.
Seems no, there's no direct Marshal for UTF-8.
There was a problem hiding this comment.
Ah, looks like it was added in a version of .NET that's more recent than the one we use: https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.marshal.ptrtostringutf8
There was a problem hiding this comment.
Current client is not .NET Core so we'll have to go with this unless we change framework.
examples/net_framework/CSharpExamples/DeepSpeechClient/DeepSpeech.cs
Outdated
Show resolved
Hide resolved
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
reuben
approved these changes
Jan 30, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default string in .NET uses UTF-16 causing invalid characters to appear as mentioned in here. This pull fixes the issue by returning the result as UTF-8.