Add TFLite accuracy estimation tool #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuben
reviewed
Jan 25, 2019
There was a problem hiding this comment.
I'm not sure about landing this tool in this repo, specially with all the copy-pasted code and the custom build instructions required for getting the appropriate native client. I think we should either import as much as possible from our code to avoid the technical debt here, even though it adds more dependencies, or land this in a separate repo.
lissyx
force-pushed
the
eval-tflite
branch
2 times, most recently
from
6c66e2b
to
ac4a682
Compare
lissyx
force-pushed
the
eval-tflite
branch
2 times, most recently
from
9c04411
to
a16425c
Compare
|
@reuben Should be better now |
reuben
approved these changes
Feb 12, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1852