Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fix #5244, use incognito: spanning in manifest #5294

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

ianb
Copy link
Contributor

@ianb ianb commented Jan 7, 2019

Soon Firefox will disable add-ons without this, or require people to opt-in

I believe this follows @mixedpuppy's recommendation

Soon Firefox will disable add-ons without this, or require people to opt-in
@ianb ianb requested a review from jaredhirsch January 7, 2019 21:42
Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredhirsch jaredhirsch merged commit 3314638 into master Jan 7, 2019
@jaredhirsch jaredhirsch deleted the incognito-spanning branch January 7, 2019 21:54
@mixedpuppy
Copy link

Soon Firefox will disable add-ons without this, or require people to opt-in

I believe this follows @mixedpuppy's recommendation

It doesn't hurt, but it wasn't necessary. System addons will continue to run as-is and still have private browsing access.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants