Fixes #5067 - add custom dimension for login type to GA #5152
Conversation
punamdahiya
changed the title
|
@ianb did a basic verification using console logs that script here is getting a correct login type. I have updated deviceId documentation with accountId details. Including @6a68 for feedback/comments. Thanks! |
docs/METRICS.md
Outdated
|
|
||
| The `cd9` dimension holds the "login type". The values can be: | ||
|
|
||
| * Empty: visitor is not logged in |
There was a problem hiding this comment.
LGTM, as long as the dashboard allows filtering on empty values of custom dimensions
There was a problem hiding this comment.
Yeah, I think we want an explicit not-logged in value here. A quick search for "custom dimension not set value" yields support threads like this one:
There was a problem hiding this comment.
Good catch! Updated to pass explicit value 'non-login' for not logged in case
docs/METRICS.md
Outdated
|
|
||
| The `cd9` dimension holds the "login type". The values can be: | ||
|
|
||
| * Empty: visitor is not logged in |
There was a problem hiding this comment.
Yeah, I think we want an explicit not-logged in value here. A quick search for "custom dimension not set value" yields support threads like this one:
punamdahiya
force-pushed
the
browser-login-cd
branch
from
8a8f709
to
17fbbcb
Compare
No description provided.