Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fix #2254, build production versions of bundles #3432

Merged
merged 1 commit into from
Aug 31, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/build-scripts/bundle_dependencies
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ build() {
echo -n "Building $(basename $dest): deps... "
browserify --list -e "$@" | sed "s!$(pwd)/!!g" | grep -v build-time > "$(depfile)"
echo -n "bundle... "
browserify -o "$dest" \
NODE_ENV=production browserify -o "$dest" \
-g [ envify --NODE_ENV production ] \
-g uglifyify \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean in relation to the $NO_UGLIFY block below? Even if we specify NO_UGLIFY, the bundle would still be minified, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, see #3433 for the rest of the story

-e "$@"
if [[ -z "$NO_UGLIFY" ]] ; then
echo -n "minimizing... "
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"body-parser": "1.17.2",
"browserify": "14.4.0",
"david": "11.0.0",
"envify": "4.1.0",
"eslint": "4.3.0",
"eslint-plugin-mozilla": "0.4.2",
"eslint-plugin-promise": "3.5.0",
Expand All @@ -70,6 +71,7 @@
"sass-lint": "1.10.2",
"selenium-webdriver": "3.5.0",
"svgo": "0.7.2",
"uglifyify": "4.0.3",
"uglify-js": "3.0.26",
"web-ext": "1.10.1"
},
Expand Down