Save resilience #2961
Save resilience #2961
Conversation
Change the Save button to not be disabled after the timeout Remove any previous clip images if Save is invoked twice
Previously they were creating empty data: URLs and causing server rejection
| @@ -27,6 +27,8 @@ loginErrorDetails = We couldn’t save your shot because there is a problem with | |||
| unshootablePageErrorTitle = We can’t screenshot this page. | |||
| unshootablePageErrorDetails = This isn’t a standard Web page, so you can’t take a screenshot of it. | |||
| selfScreenshotErrorTitle = You can’t take a shot of a Firefox Screenshots page! | |||
| # Fired when someone makes a zero-width or zero-height selection | |||
| emptySelectionErrorTitle = Your selection is too small | |||
There was a problem hiding this comment.
@flodolo We're aiming for 55, but have a new string to add. Is it possible to get strings uplifted after 55 graduates to Beta?
There was a problem hiding this comment.
Localization happens in GitHub, outside of mozilla-central, so you're not bound to trains: the content that you land in mozilla-central is not exposed to localizers, so no problem with uplifts.
Having said that, the sooner you land, the better. And if you're planning to enable in 55, website's localization is getting kind of late.
There was a problem hiding this comment.
This is a very obscure error: the user has the resize the selection down to zero height or width to encounter it, so I think if it doesn't get localized the impact will be very small.
This deals with several issues from #2957: