Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Save timing information in GA #936

Closed
ianb opened this issue Jan 7, 2016 · 4 comments
Closed

Save timing information in GA #936

ianb opened this issue Jan 7, 2016 · 4 comments
Assignees
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Jan 7, 2016

We can use User Timings to save time information to GA. It would be nice to measure a few things using this, like shot uploads. This might go through /event or might have its own server endpoint? Same pattern though.

@ianb ianb added this to the First Launch milestone Jan 7, 2016
@ianb ianb closed this as completed in 2470973 Jan 28, 2016
ianb added a commit that referenced this issue Jan 28, 2016
r? ianbicking Fixes #936 Save shot timing info in ga.
@ianb
Copy link
Contributor Author

ianb commented Nov 4, 2016

I don't believe we're getting information from these.

@ianb ianb reopened this Nov 4, 2016
@ianb ianb removed this from the First Launch milestone Nov 4, 2016
@ianb ianb unassigned fzzzy Nov 4, 2016
@ianb ianb added this to the Cygnus X-1 milestone Nov 9, 2016
@ianb
Copy link
Contributor Author

ianb commented Nov 14, 2016

Note there is a sendTiming() function in addon/lib/req.js – we currently only send that for extractWorker. We should look in GA to see how that data looks, and verify that the approach is good. Then we should add timing for some of the other steps.

@ianb ianb self-assigned this Nov 15, 2016
@ianb
Copy link
Contributor Author

ianb commented Nov 15, 2016

Here's what the data we have looks like:

image

So I think it's fine, we just have to add more. Here's my thought:

  • add-ids
  • make-static-html
  • Total time for collection (collect-information)
  • destroy (general teardown time)
  • Total takeShot (take-shot)
  • Upload specifically (upload)

@ianb
Copy link
Contributor Author

ianb commented Nov 15, 2016

We should change /timing as well, use the proper parameters, and I think support batch operations.

@fzzzy fzzzy closed this as completed in 352398c Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants