Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Stop sending metrics if server can't be contacted #5293

Closed
ianb opened this issue Jan 7, 2019 · 1 comment
Closed

Stop sending metrics if server can't be contacted #5293

ianb opened this issue Jan 7, 2019 · 1 comment
Assignees
@ianb
Milestone
Server messaging ...

Comments

@ianb
Copy link
Contributor

ianb commented Jan 7, 2019

Per this comment, we may want to stop trying to send metrics if the server can't be contacted. Currently only if the server returns 410 will we stop sending metrics.
@ianb ianb mentioned this issue Jan 7, 2019
Merged
@clouserw
Copy link
Collaborator

clouserw commented Jan 8, 2019

Let's do any 4xx response

@clouserw clouserw added this to the Server messaging release milestone Jan 8, 2019
@ianb ianb self-assigned this Jan 8, 2019
ianb added a commit that referenced this issue Jan 15, 2019
@ianb
Fix #5293, stop sending metrics if server isn't available
9bc130d 
Also adds logic to not send timing information if server is unavailable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
Server messaging release
Development

No branches or pull requests
2 participants
@ianb @clouserw