Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Screenshots is shipping browser test files as part of the Firefox build #5241

Closed
Standard8 opened this issue Dec 11, 2018 · 0 comments
Closed
Assignees
Milestone

Comments

@Standard8
Copy link
Contributor

In the generated section of screenshot's moz.build, various test files are being set as FINAL_TARGET_FILES. This means they're being including in the xpi that is shipped with Firefox itself.

These shouldn't be necessary as the build system automatically bundles up test files separately to Firefox itself.

Additionally, the .eslintrc.yml isn't actually being shipped, I suspect because it is a dot file the build system is ignoring it somehow.

https://searchfox.org/mozilla-central/rev/adcc169dcf58c2e45ba65c4ed5661d666fc3ac74/browser/extensions/screenshots/moz.build#463-467

FINAL_TARGET_FILES.features['screenshots@mozilla.org']["test"]["browser"] += [
  'test/browser/.eslintrc.yml',
  'test/browser/browser.ini',
  'test/browser/browser_screenshots_ui_check.js'
]
@johngruen johngruen added this to the EOSL milestone Dec 12, 2018
@ianb ianb self-assigned this Jan 7, 2019
@ianb ianb closed this as completed in b4d3873 Feb 12, 2019
ianb added a commit that referenced this issue Feb 12, 2019
Fix #5241, don't ship files in test/ with Firefox
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants