Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[FxA] Settings page UI when accessed directly using /settings #5185

Closed
punamdahiya opened this issue Nov 16, 2018 · 5 comments
Closed

[FxA] Settings page UI when accessed directly using /settings #5185

punamdahiya opened this issue Nov 16, 2018 · 5 comments

Comments

@punamdahiya
Copy link
Contributor

Scope of this bug is to discuss /settings page when accessed directly from url in firefox and non-firefox browsers
a) on non-Firefox browsers,
i) if not signed into Firefox Account, page with message "You must have Screenshots installed"
non-firefox-not-signedin

ii) if signed into Firefox Account,
non-firefox-signedin

b) On Firefox browser

i) If not signed in Firefox Account
firefox-not-signed-in

ii) if signed into Firefox Account
firefox-signedin

@punamdahiya punamdahiya changed the title [FxA] Settings page UI when accessed directly using /settings url [FxA] Settings page UI when accessed directly using /settings Nov 16, 2018
@punamdahiya
Copy link
Contributor Author

@johngruen we should review Firefox browsers not signed in settings pageUI, with options as
a) remove it as we have sign-in available from header
b) Update strings and messaging to remove sync

@punamdahiya
Copy link
Contributor Author

Submitting fix that shows settings page only when user is authenticated with Firefox account. If user has not previously authenticated, accessing /settings redirects to homepage

punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Nov 20, 2018
@johngruen johngruen added this to the Sprint 27 (66-1) milestone Nov 20, 2018
@johngruen
Copy link
Contributor

Let's redirect to the homepage

@SoftVision-CosminMuntean

I have verified these scenarios using the latest Screenshtos dev version but I have observed the following behaviors:

  1. On non-Firefox browsers, if you are not signed into Firefox Account, if you navigate directly to the https://screenshots.dev.mozaws.net/settings, the "You must have Screenshots installed" message is still displayed.
    But, from what I understand, now that the PR Fixes #5185 - Access settings page directly from url #5207 landed, you should be redirected to the homepage.

  2. On Firefox browsers if you are not signed and you don't have any shots uploaded when you navigate directly to the "Settings" page, the "You must have Screenshots installed" message is displayed.
    However, If you have a shot uploaded and you access directly the "Settings" page you are correctly redirected to the "Settings" page.

@punamdahiya are these behaviors intended and I misunderstood the issue?

@punamdahiya
Copy link
Contributor Author

I have verified these scenarios using the latest Screenshtos dev version but I have observed the following behaviors:

1. On non-Firefox browsers, if you are not signed into Firefox Account, if you navigate directly to the https://screenshots.dev.mozaws.net/settings, the "You must have Screenshots installed" message is still displayed.
   But, from what I understand, now that the PR #5207 landed, you should be redirected to the homepage.

That's correct, accessing /settings page directly from url when not signed in should redirect user to homepage

2. On Firefox browsers if you are not signed and you don't have any shots uploaded when you navigate directly to the "Settings" page, the "You must have Screenshots installed" message is displayed.
   However, If you have a shot uploaded and you access directly the "Settings" page you are correctly redirected to the "Settings" page.

With the fix in this PR, for both Firefox and non-Firefox browsers, accessing /settings url when not signed in should redirect to home page

@punamdahiya are these behaviors intended and I misunderstood the issue?

@SoftVision-CosminMuntean fix of this issue should be reflected in >=36.2.0 version on dev which got deployed today and should work now. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants