Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[FxA] Do not rely on wantsauth for FxA cookie-setting #4974

Closed
ianb opened this issue Oct 1, 2018 · 0 comments
Closed

[FxA] Do not rely on wantsauth for FxA cookie-setting #4974

ianb opened this issue Oct 1, 2018 · 0 comments
Assignees
@punamdahiya
Milestone
Sprint 23 (65-0)

Comments

@ianb
Copy link
Contributor

ianb commented Oct 1, 2018

Per some of the comments in #4966, we should be setting the accountid cookie in the confirm-login endpoint. We should also remove the special ?auth=1 handling, which is only necessary because it's triggering wantsauth.
@johngruen johngruen added this to the Sprint 23 (65-0) milestone Oct 2, 2018
@punamdahiya punamdahiya self-assigned this Oct 3, 2018
@ianb ianb closed this as completed in c076b55 Oct 8, 2018
ianb added a commit that referenced this issue Oct 8, 2018
@ianb
Merge pull request #4998 from punamdahiya/4974_wantsauth
16f6c5f 
Fixes #4974 - Remove wantsauth dependency for setting FxA cookie
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@punamdahiya punamdahiya

Labels
None yet
Projects
None yet
Milestone
Sprint 23 (65-0)
Development

No branches or pull requests
3 participants
@ianb @punamdahiya @johngruen