Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

color option in new text tool does not work #4741

Closed
cadeyrn opened this issue Aug 4, 2018 · 3 comments
Closed

color option in new text tool does not work #4741

cadeyrn opened this issue Aug 4, 2018 · 3 comments
Assignees
Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team. [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@cadeyrn
Copy link

cadeyrn commented Aug 4, 2018

The color option in the new text tool does not work at all. The text is always black.

bildschirmfoto 2018-08-04 um 23 24 22

@ghost ghost added this to the Sprint 19 (63-3) milestone Aug 6, 2018
@SoftVision-CosminMuntean

I have managed to reproduce this issue on latest Firefox (61.0.1) release and also latest Nightly (63.0a1) build.

[Stepst to reproduce]:

  1. Open the latest Firefox release and navigate to "about:preferences" page.
  2. Click the "Choose" button from the "Language and Apperance" section.
  3. Add the "German [de]" language on the first position and click the "OK"button.
  4. Navigate to any website and save a selection.
  5. Click the "Edit this image" button.
  6. Click the "Add Text" button.
  7. Change the color of the text and observe the behavior.

[Expected Results]:

  • The color is correctly applied.

[Actual Results]:

  • The color is not applied.

[Notes]:

  • Here is a screen recording of the issue:
    color picker 3

@punamdahiya
Copy link
Contributor

color picker CSS is picking colorName from title attribute which gets localized and doesn't work for languages other than en. Will submit fix to pick colorName from a new dataset attribute inside color-picker

punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 6, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Aug 8, 2018
punamdahiya added a commit that referenced this issue Aug 8, 2018
Fixes #4741 - Update color in text tool for localized sites
@SoftVision-CosminMuntean

I have verified this issue using latest Screenshots (34.0.0) dev version and it's no longer reproducible. Tested on Windows 10 x64, Windows 7 x64, Mac 10.13 and Arch Linux.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added [QA]:Verified fixed Label for QA to mark verified fixed issues [QA]:Other issue Valid issues logged by other people than the Softvision QA team. labels Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team. [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

3 participants