Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Annotations] Encapsulate text tool styles using sass nesting #4701

Closed
jaredhirsch opened this issue Jul 23, 2018 · 0 comments
Closed

[Annotations] Encapsulate text tool styles using sass nesting #4701

jaredhirsch opened this issue Jul 23, 2018 · 0 comments

Comments

@jaredhirsch
Copy link
Member

Right now, there are a lot of styles in static/css/frame.scss that are specific to the text editor tool.

Instead of those styles being declared at top level, it would be nice to use the fact that each tool puts a different class name on the #canvas-container element, and use sass nesting to encapsulate tool-specific styles.

For instance, the color styles currently scoped to #text-input, like:

#text-input.white {
  @include type-color($bg-black, white);
}

seem to work fine if nested under the more general .textTool selector:

.textTool {
  .white {
    @include type-color($bg-black, white);
  }
}

Related to #4700.

@ianb ianb added this to the Stretch milestone Jul 25, 2018
@punamdahiya punamdahiya changed the title Encapsulate text tool styles using sass nesting [Annotations] Encapsulate text tool styles using sass nesting Jul 27, 2018
@chenba chenba mentioned this issue Sep 10, 2018
@chenba chenba closed this as completed Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants