Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Annotations] Text width should not extend beyond 5px inside canvas #4680

Closed
johngruen opened this issue Jul 20, 2018 · 1 comment
Closed

[Annotations] Text width should not extend beyond 5px inside canvas #4680

johngruen opened this issue Jul 20, 2018 · 1 comment
Assignees
@punamdahiya
Milestone
Sprint 18 (63-2)

Comments

@johngruen
Copy link
Contributor

After playing with the canvas, i think we need to adjust the max string length so that text input cannot exceed the width of the canvas - 10px (5 on each side)

Now there's an edge case where the user could type longer strings with a small font and then resize, but i think that's OK
@johngruen johngruen added the P1 label Jul 20, 2018
@punamdahiya
Copy link
Contributor

Updating title of the bug to reflect description of the bug that is Text input width should not be extend beyond 5px inside canvas

@punamdahiya punamdahiya changed the title [Annotations] Text should not be draggable beyond 5px inside canvas [Annotations] Text width should not extend beyond 5px inside canvas Jul 20, 2018
@ianb ianb removed the P1 label Jul 23, 2018
@ianb ianb added this to the Sprint 18 (63-2) milestone Jul 23, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Jul 25, 2018
@punamdahiya
Fixes mozilla-services#4680 - Text width should not extend beyond 5px…
92f1116 
… inside canvas
@punamdahiya punamdahiya mentioned this issue Jul 25, 2018
Merged
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Jul 25, 2018
@punamdahiya
Fixes mozilla-services#4680 - Text width should not extend beyond 5px…
60e6f1b 
… inside canvas
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Jul 26, 2018
@punamdahiya
Fixes mozilla-services#4680 - Text width should not extend beyond 5px…
8089dfa 
… inside canvas
punamdahiya added a commit that referenced this issue Jul 26, 2018
@punamdahiya
Merge pull request #4708 from punamdahiya/4680_set_text_limit
220492b 
Fixes #4680 - Text width should not extend beyond 5px inside canvas
This was referenced Jul 26, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@punamdahiya punamdahiya

Labels
None yet
Projects
None yet
Milestone
Sprint 18 (63-2)
Development

No branches or pull requests
3 participants
@ianb @punamdahiya @johngruen