Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Annotations] The image is wrongly dragged at first resize of a selection in crop mode #4456

Closed
SoftVision-CosminMuntean opened this issue May 15, 2018 · 3 comments · Fixed by #4457
Assignees
Labels
[QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 62.0a1
  • Screenshots 32.1.0 dev

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" boolean pref is set to "false".
  • The "extensions.legacy.enabled" boolean pref is set tot "true".
  • The "extensions.install.requireBuiltInCerts" Boolean pref is set to "false".
  • Have the Screenshots 32.1.0 dev version installed from here, on a new clean profile.
  • Have a saved shot link.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites and navigate to the saved shot link.
  2. Click the "Edit this image" button.
  3. Click the "Crop" button.
  4. Perform a selection on the image.
  5. Resize the image without releasing the mouse.
  6. Observe the behavior.

[Expected result]:

  • The selection is correctly resized.

[Actual results]:

  • The image is dragged.

[Notes]:

  • After releasing the mouse the image is released but the selection can still be resized.
  • Here is a screen recording with the issue:
    crop selection resize
@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Major issue Label for QA to mark major issues logged label May 15, 2018
@chenba chenba self-assigned this May 15, 2018
@chenba
Copy link
Collaborator

chenba commented May 15, 2018

What's the being dragged are teh divs for the crop selection highlight and background (which are wrapped in a parent div). It also looks like the right hand side background div is too wide.

chenba added a commit to chenba/screenshots that referenced this issue May 15, 2018
- Also fix the width of right hand side background div.
@chenba
Copy link
Collaborator

chenba commented May 15, 2018

PR's created. Adding to current sprint.

@chenba chenba added this to the Sprint 13 (62-1) 👾 milestone May 15, 2018
jaredhirsch pushed a commit that referenced this issue May 24, 2018
- Also fix the width of right hand side background div.
@SoftVision-CosminMuntean
Copy link
Author

I have verified this issue using latest Screenshots (32.1.0) dev version and the issue is no longer reproducible. Tested on Windows 7 x64, Mac 10.13 and Arch Linux.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 25, 2018
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
…es#4457)

- Also fix the width of right hand side background div.
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants