Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

If the title of a newly created shot was edited, the shot looks broken on "My Shots" page #3913

Closed
SoftVision-CosminMuntean opened this issue Dec 12, 2017 · 3 comments
Assignees
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 59.0a1
  • Screenshots 26.0.0 dev

[Affected Platforms]:

  • All Windows
  • All Mac OS
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" boolean pref is set to "false".
  • The "extensions.legacy.enabled" boolean pref is set tot "true".
  • Have the Screenshots 26.0.0 dev version installed from here, on a new clean profile.

[Steps to reproduce]:

  1. Open latest Nightly build with the profile from prerequisites and navigate to any website.
  2. Save a selection on the page.
  3. Edit the shot title and click the "My Shots" button.
  4. Observe the saved shot.

[Expected result]:

  • The shot is correctly displayed on "My Shots" page.

[Actual result]:

  • The shot looks broken on "My Shots" page.

[Notes]:

  • This issue is not reproducible on latest Nightly 59.0a1 build using Screenshots 25.0.0 version.
  • Here is a screen recording with the issue:
    broken shot
@chenba
Copy link
Collaborator

chenba commented Dec 12, 2017

I suspect a (failed) thumbnail re-gen was attempted on the title save.

@chenba chenba self-assigned this Dec 15, 2017
chenba added a commit to chenba/screenshots that referenced this issue Dec 15, 2017
@chenba chenba added the server label Dec 15, 2017
chenba added a commit to chenba/screenshots that referenced this issue Dec 16, 2017
@ghost ghost modified the milestones: Sprint 3 (59-2) 📥, Sprint 4 (59-3) 😯 Dec 18, 2017
@ianb ianb closed this as completed in #3917 Jan 3, 2018
@SoftVision-CosminMuntean
Copy link
Author

This issue is still reproducible on Screenshots (27.0.0) dev version. But, it seems that the saved shots now looks a little bit different than before the PR was merged.
See this screenshot:
screenshot-2018-1-4 my shots

@SoftVision-CosminMuntean
Copy link
Author

I have retested this issue using Screenshots 28.0.0 dev and stage version and is no longer reproducible. The shot is correctly displayed on "My Shots" page, if the title of was edited.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

2 participants