Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Load scripts at document_start #3633

Closed
ianb opened this issue Oct 12, 2017 · 0 comments
Closed

Load scripts at document_start #3633

ianb opened this issue Oct 12, 2017 · 0 comments
Assignees
@chenba
Labels
firefox Something that has to ship in the add-on in Firefox perf Performance-related
Milestone
Bucket ☕️

Comments

@ianb
Copy link
Contributor

ianb commented Oct 12, 2017

Right now (code here) we wait until document_end to load the selector code into a content page. I think we should move back to document_start. This will improve the performance and starting Screenshots on slow-loading pages (e.g., most news sites).

I believe we chose document_end to avoid some bug, though I can't find what bug exactly. Note this code was changed in 0cec951, but that change may have actually sped up the activation slightly.
@ghost ghost added perf Performance-related firefox Something that has to ship in the add-on in Firefox labels Oct 13, 2017
@ghost ghost added this to the Launch 58 milestone Oct 13, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 15, 2017
@chenba
Load scripts at document_start. (mozilla-services#3633)
6e4f27d
@chenba chenba self-assigned this Oct 16, 2017
@chenba chenba mentioned this issue Oct 16, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
firefox Something that has to ship in the add-on in Firefox perf Performance-related
Projects
None yet
Milestone
Bucket ☕️
Development

No branches or pull requests
2 participants
@ianb @chenba