Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Remove browserAction #3468

Closed
ianb opened this issue Sep 6, 2017 · 2 comments
Closed

Remove browserAction #3468

ianb opened this issue Sep 6, 2017 · 2 comments
Assignees
@ianb
Milestone
General Release 57

Comments

@ianb
Copy link
Contributor

ianb commented Sep 6, 2017

We've switched to a pageAction for Firefox 57 / Photon. But we kept browserAction support so we could support older Firefox version. After discussion we realized we won't be deploying the current master to any versions of Firefox older than 57, so we can just remove the browserAction entirely.

This should remove the browserAction from manifest.json, and related code from bootstrap.js. We should probably get a review on this change from Mossop or kmag (if #3463 is done we could experiment with it for this).
@ianb ianb mentioned this issue Sep 6, 2017
Closed
@ghost ghost added this to the Stretch milestone Sep 7, 2017
@gijsk
Copy link
Collaborator

gijsk commented Sep 12, 2017

Seems like we should get this in before the 57 merge (on the 20th/21st, so just over a week away), or beta ends up with https://bugzilla.mozilla.org/show_bug.cgi?id=1396438 . Is "stretch" the appropriate milestone for this? @ianb ?

@ianb ianb removed this from the Stretch milestone Sep 12, 2017
@ghost ghost assigned ianb Sep 12, 2017
@ghost ghost added this to the General Release 57 milestone Sep 12, 2017
@ianb
Copy link
Contributor Author

ianb commented Sep 12, 2017

During testing I'm seeing this error in the Browser Console, during the selection process: TypeError: window is null WebNavigationFrames.jsm:59:1 – but these changes don't seem to affect the error one way or the other, so at least it's probably unrelated to this change.

ianb added a commit that referenced this issue Sep 12, 2017
@ianb
Fix #3468, remove browserAction
177e6b4 
This changes the add-on to require the Photon page action, with no fallback to a browserAction
- Removes test for Photon (assumes it is present)
- Removes bootstrap.js code that deletes the browserAction button
- Removes webextension code references to browserAction
- Removes Photon conditionals (i.e., assume it's always Photon)
- Make 57a1 the minimum version for the webextension/install.rdf
@ianb ianb closed this as completed in d4c56ae Sep 13, 2017
ianb added a commit that referenced this issue Sep 13, 2017
@ianb
Merge pull request #3486 from mozilla-services/remove-browseraction
234fffc 
Fix #3468, remove browserAction
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
General Release 57
Development

No branches or pull requests
2 participants
@ianb @gijsk