This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix #2254, build production versions of bundles #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This always builds bundles as a production build. envify and uglifyify should also help improve overall bundle sizes
Codecov Report
@@ Coverage Diff @@
## master #3432 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 25 25
Lines 1425 1425
Branches 260 260
=======================================
Hits 745 745
Misses 680 680Continue to review full report at Codecov.
|
jaredhirsch
approved these changes
Aug 31, 2017
pdehaan
reviewed
Aug 31, 2017
| browserify -o "$dest" \ | ||
| NODE_ENV=production browserify -o "$dest" \ | ||
| -g [ envify --NODE_ENV production ] \ | ||
| -g uglifyify \ |
There was a problem hiding this comment.
What does this mean in relation to the $NO_UGLIFY block below? Even if we specify NO_UGLIFY, the bundle would still be minified, no?
There was a problem hiding this comment.
Yup, see #3433 for the rest of the story
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always builds bundles as a production build. envify and uglifyify should also help improve overall bundle sizes