Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Unoptimized gzip and cache settings #3202

Closed
digitarald opened this issue Jul 24, 2017 · 7 comments
Closed

Unoptimized gzip and cache settings #3202

digitarald opened this issue Jul 24, 2017 · 7 comments
Assignees
Labels
P2 perf Performance-related

Comments

@digitarald
Copy link

More details on https://www.webpagetest.org/result/170724_VE_23RP/1/performance_optimization/

Missing gzip: https://screenshots.firefox.com/static/img/spinner.svg?rev=8.1.0-465-gcce97ba

Caching can be extended to multiple days for most static resources, given that the rev is in the query (to some, why not to all?):

image

@ghost ghost added this to the General Release 57 milestone Jul 26, 2017
@ghost ghost added the perf Performance-related label Jul 26, 2017
@johngruen johngruen added the P2 label Aug 17, 2017
@ghost
Copy link

ghost commented Sep 22, 2017

@relud is turning on gzip a switch you can flip?

@relud
Copy link
Member

relud commented Sep 22, 2017

yeah, there's an nginx setting for it. what content-types should we compress? I have to specify each of them, except for text/html which is automatic. looks like a good list for you would be image/png image/svg+xml application/javascript text/css, but I don't know all the types that screenshots serves, so I'm just guessing.

the settings look like this: https://github.com/mozilla-services/cloudops-deployment/blob/master/projects/normandy/puppet/modules/normandy/files/http_normandy_root_location.conf#L21-L23

@relud
Copy link
Member

relud commented Sep 22, 2017

this should enable it, on the types i listed above: https://github.com/mozilla-services/cloudops-deployment/pull/1166

@ianb
Copy link
Contributor

ianb commented Sep 22, 2017

We shouldn't have compression on image/png, they are already fully compressed. The only thing I'd add is application/x-font-ttf and application/json

@relud
Copy link
Member

relud commented Sep 22, 2017

okay, i updated the list to image/svg+xml application/javascript application/json application/x-font-ttf text/css in that PR

@relud
Copy link
Member

relud commented Sep 27, 2017

okay, mozilla-services/cloudops-deployment#1166 is merged, so the next to deploys to dev/stage will pick up this change.

@ianb ianb self-assigned this Oct 3, 2017
ianb added a commit that referenced this issue Oct 3, 2017
This is relatively safe since we use commit-hash-based cache busters on URLs.
This fixes one of the last issues from #3202
@ianb
Copy link
Contributor

ianb commented Oct 3, 2017

One of the last issues fixed in #3592, and #3590 and #3591 cover the rest.

@ianb ianb closed this as completed Oct 3, 2017
jaredhirsch pushed a commit that referenced this issue Oct 3, 2017
This is relatively safe since we use commit-hash-based cache busters on URLs.
This fixes one of the last issues from #3202
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 perf Performance-related
Projects
None yet
Development

No branches or pull requests

4 participants