Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Remove metrics/controller.js code #3069

Closed
ianb opened this issue Jun 28, 2017 · 0 comments · Fixed by #4483
Closed

Remove metrics/controller.js code #3069

ianb opened this issue Jun 28, 2017 · 0 comments · Fixed by #4483
Assignees
@ianb
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product
Milestone
Stretch

Comments

@ianb
Copy link
Contributor

ianb commented Jun 28, 2017

There is dead code in pages/metrics/controller.js (note the code isn't used in metrics/view.js so it's not meaningful).
@ianb ianb added this to the Stretch milestone Jun 28, 2017
@ianb ianb added the code Code quality issue, that does not have any outward effect on the product label Jan 10, 2018
@ianb ianb added the code quality Not a bug, targeted for fixing in 2018 label Jan 17, 2018
@ghost ghost assigned ianb May 21, 2018
ianb added a commit that referenced this issue May 21, 2018
@ianb
Fix #4278, remove uninteresting and long tables from /metrics
8e2c290 
Also fix #3069, remove controller.js for /metrics
@ianb ianb mentioned this issue May 21, 2018
Merged
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
@ianb
Fix mozilla-services#4278, remove uninteresting and long tables from …
a5bb4b3 
…/metrics

Also fix mozilla-services#3069, remove controller.js for /metrics
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product
Projects
None yet
Milestone
Stretch
Development

Successfully merging a pull request may close this issue.

Fix #4278, remove uninteresting and long tables from /metrics mozilla-services/screenshots
1 participant
@ianb