Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Try to remove resolveUrl from shot.js #2659

Closed
ianb opened this issue Apr 12, 2017 · 0 comments
Closed

Try to remove resolveUrl from shot.js #2659

ianb opened this issue Apr 12, 2017 · 0 comments
Assignees
@chenba
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox
Milestone
Sprint 8 (61-0) 😮

Comments

@ianb
Copy link
Contributor

ianb commented Apr 12, 2017

I don't think we should need to do this at all in that context.
@ianb ianb mentioned this issue Apr 12, 2017
Closed
@ghost ghost added this to the Stretch milestone Apr 13, 2017
@ianb ianb added code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox labels Jan 10, 2018
@ianb ianb added the code quality Not a bug, targeted for fixing in 2018 label Jan 17, 2018
chenba added a commit to chenba/screenshots that referenced this issue Mar 13, 2018
@chenba
Remove some code around favicon url. (mozilla-services#2659)
1300069
@chenba chenba mentioned this issue Mar 13, 2018
Merged
@chenba chenba self-assigned this Mar 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Milestone
Sprint 8 (61-0) 😮
Development

No branches or pull requests
3 participants
@ianb @chenba @johngruen