Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Create script to copy Page Shot into Firefox #2318

Closed
ianb opened this issue Mar 8, 2017 · 2 comments
Closed

Create script to copy Page Shot into Firefox #2318

ianb opened this issue Mar 8, 2017 · 2 comments
Assignees
@Standard8
Milestone
General Release 55

Comments

@ianb
Copy link
Contributor

ianb commented Mar 8, 2017

We should have a script that will import the addon (everything in addon/ after running make addon) into the Firefox tree.
@ianb ianb mentioned this issue Mar 8, 2017
Closed
@ianb ianb added the releng label Mar 8, 2017
@ianb ianb modified the milestone: Page Shot in 54 Mar 8, 2017
@Standard8 Standard8 self-assigned this Mar 8, 2017
@Standard8
Copy link
Contributor

I have a WIP Makefile change that'll do an export. I have a bit more digging into #2319 to do before I decide if it is the right way to go or not.

In the meantime, here's a simple try push (just tests etc) to check for any adverse impacts:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b6533ee47272f4c8712a081af342cdeef12ae1e

@Standard8 Standard8 mentioned this issue Mar 10, 2017
Closed
@Standard8
Copy link
Contributor

The PR referenced provides an make export_addon command. This can be modified via EXPORT_MC_LOCATION environment variable to change where it is exported to.

There's a patch on bug 1346825 that will provide the build system hook-up.

Standard8 added a commit that referenced this issue Mar 14, 2017
@Standard8
Merge pull request #2362 from mozilla-services/export-command
c58ea33 
Fixes #2318: Provides export_addon makefile rule to export pageshot into a mozilla-central based repository.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Standard8 Standard8

Labels
None yet
Projects
None yet
Milestone
General Release 55
Development

No branches or pull requests
2 participants
@ianb @Standard8