-
Notifications
You must be signed in to change notification settings - Fork 128
Notify user when Full Page is cut off #2129
Comments
Actually, I think this needs product:
|
@ianb do we have a histogram of shot sizes somewhere. that would be cool to have in general? we might be able to reason about lifting or pushing out the restriction. Otherwise, maybe just an alert box for now? |
In Nightly on Windows, "Save Full Page" gives me an image silently truncated at a height of 6250 pixels, while the fullpage tool gives me all 8818 pixels. Someone using "Save Full Page" for research/documentation purposes will be sorely disappointed to discover it is not actually the full page. Could you display a warning and offer the other function instead? E.g., "Page exceeds current maximum height for Save Full Page. [Save Partial Page] [Download Instead] [Cancel]" |
What's the reason for the limit? Could users at least change a setting to lift it? also #220 for changing filetype for large shots |
Here's what this should look like: The string is: Here's the styles i used to mock that element up:
Note, that message should only appear if the image is cut off. |
Adds a new captureType, fullPageTruncated
Adds a new captureType, fullPageTruncated
Adds a new captureType, fullPageTruncated
Fix #2129, notify user when full page is cut off
Adds a new captureType, fullPageTruncated
Adds a new captureType, fullPageTruncated Fixes upstream bug: mozilla-services/screenshots#2129 Export of commit: mozilla-services/screenshots@e31c321 MozReview-Commit-ID: HB3e5Q24afT --HG-- extra : rebase_source : 1780f8acc7af0ae1b7c60c383460b8e62dd7e786
Adds a new captureType, fullPageTruncated Fixes upstream bug: mozilla-services/screenshots#2129 Export of commit: mozilla-services/screenshots@e31c321 MozReview-Commit-ID: HB3e5Q24afT
Adds a new captureType, fullPageTruncated Fixes upstream bug: mozilla-services/screenshots#2129 Export of commit: mozilla-services/screenshots@e31c321 MozReview-Commit-ID: HB3e5Q24afT
Adds a new captureType, fullPageTruncated Fixes upstream bug: mozilla-services/screenshots#2129 Export of commit: mozilla-services/screenshots@e31c321 MozReview-Commit-ID: HB3e5Q24afT
Adds a new captureType, fullPageTruncated Fixes upstream bug: mozilla-services/screenshots#2129 Export of commit: mozilla-services/screenshots@e31c321 MozReview-Commit-ID: HB3e5Q24afT UltraBlame original commit: 933b30269777f718a14d2fc379e563a051b14618
Adds a new captureType, fullPageTruncated Fixes upstream bug: mozilla-services/screenshots#2129 Export of commit: mozilla-services/screenshots@e31c321 MozReview-Commit-ID: HB3e5Q24afT UltraBlame original commit: 933b30269777f718a14d2fc379e563a051b14618
Adds a new captureType, fullPageTruncated Fixes upstream bug: mozilla-services/screenshots#2129 Export of commit: mozilla-services/screenshots@e31c321 MozReview-Commit-ID: HB3e5Q24afT UltraBlame original commit: 933b30269777f718a14d2fc379e563a051b14618
We have a 5000px limit to images, even Full Page. People hit that and then are confused why the images are limited. We should tell them.
The text was updated successfully, but these errors were encountered: