Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Notify user when Full Page is cut off #2129

Closed
ianb opened this issue Jan 25, 2017 · 7 comments
Closed

Notify user when Full Page is cut off #2129

ianb opened this issue Jan 25, 2017 · 7 comments
Assignees
Labels
firefox Something that has to ship in the add-on in Firefox

Comments

@ianb
Copy link
Contributor

ianb commented Jan 25, 2017

We have a 5000px limit to images, even Full Page. People hit that and then are confused why the images are limited. We should tell them.

@ianb ianb added this to the Stretch milestone Jan 25, 2017
@jaredhirsch jaredhirsch self-assigned this Mar 30, 2017
@jaredhirsch
Copy link
Member

Actually, I think this needs product:

  • Do we really need to max the height at 5k? If it's just text on a white background, the resulting image might not be that big, compared to a high-res video or gradient background. Bigger, related question: what should we do if a screenshot is too big (filesize)? Should we warn the user or just lossy-compress the image or...?
  • If we want to keep this restriction, should we warn users when they hover the 'shoot full page' button? should we create a selection box 5000 pixels high, then scroll down to its bottom edge, and then show a warning along the lines of "Screenshots can't be more than 5000 pixels long, so stuff below this line will not be included"?

@jaredhirsch jaredhirsch removed their assignment Mar 30, 2017
@johngruen
Copy link
Contributor

@ianb do we have a histogram of shot sizes somewhere. that would be cool to have in general? we might be able to reason about lifting or pushing out the restriction. Otherwise, maybe just an alert box for now?

@jscher2000
Copy link

In Nightly on Windows, "Save Full Page" gives me an image silently truncated at a height of 6250 pixels, while the fullpage tool gives me all 8818 pixels. Someone using "Save Full Page" for research/documentation purposes will be sorely disappointed to discover it is not actually the full page. Could you display a warning and offer the other function instead? E.g., "Page exceeds current maximum height for Save Full Page. [Save Partial Page] [Download Instead] [Cancel]"

@heyakyra
Copy link

What's the reason for the limit? Could users at least change a setting to lift it?

also #220 for changing filetype for large shots

@beingalink
Copy link

In combination with #3215 or #3479 the 5000px limit becomes a problem rather quickly.

@johngruen johngruen modified the milestones: Stretch, General Release 57 Sep 22, 2017
@johngruen johngruen added the firefox Something that has to ship in the add-on in Firefox label Sep 22, 2017
@ghost ghost assigned johngruen Sep 22, 2017
@ianb
Copy link
Contributor Author

ianb commented Sep 22, 2017

Roughly the UX proposed is to just put a little text on the full page preview:

image

@johngruen
Copy link
Contributor

johngruen commented Sep 25, 2017

@ianb

Here's what this should look like:

screen shot 2017-09-25 at 3 26 19 pm

The string is:
Full page shots are limited to 5000px for now.
This image has been cropped to 5000px.

Here's the styles i used to mock that element up:

  background: rgba(0,0,0,.8);
  bottom: 0;
  color: #fff;
  font: message-box;
  padding: 10px;
  position: absolute;
  text-align: center;
  width: 100%;
  z-index: 2;

Note, that message should only appear if the image is cut off.

@johngruen johngruen assigned ianb and unassigned johngruen Sep 25, 2017
ianb added a commit that referenced this issue Sep 26, 2017
Adds a new captureType, fullPageTruncated
ianb added a commit that referenced this issue Sep 26, 2017
Adds a new captureType, fullPageTruncated
ianb added a commit that referenced this issue Sep 26, 2017
Adds a new captureType, fullPageTruncated
@ianb ianb closed this as completed in aa97577 Sep 28, 2017
ianb added a commit that referenced this issue Sep 28, 2017
Fix #2129, notify user when full page is cut off
ianb added a commit that referenced this issue Sep 28, 2017
Adds a new captureType, fullPageTruncated
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 4, 2017
Adds a new captureType, fullPageTruncated

Fixes upstream bug: mozilla-services/screenshots#2129
Export of commit: mozilla-services/screenshots@e31c321

MozReview-Commit-ID: HB3e5Q24afT

--HG--
extra : rebase_source : 1780f8acc7af0ae1b7c60c383460b8e62dd7e786
xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this issue Oct 4, 2017
Adds a new captureType, fullPageTruncated

Fixes upstream bug: mozilla-services/screenshots#2129
Export of commit: mozilla-services/screenshots@e31c321

MozReview-Commit-ID: HB3e5Q24afT
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue Oct 5, 2017
Adds a new captureType, fullPageTruncated

Fixes upstream bug: mozilla-services/screenshots#2129
Export of commit: mozilla-services/screenshots@e31c321

MozReview-Commit-ID: HB3e5Q24afT
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue Oct 9, 2017
Adds a new captureType, fullPageTruncated

Fixes upstream bug: mozilla-services/screenshots#2129
Export of commit: mozilla-services/screenshots@e31c321

MozReview-Commit-ID: HB3e5Q24afT
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
Adds a new captureType, fullPageTruncated

Fixes upstream bug: mozilla-services/screenshots#2129
Export of commit: mozilla-services/screenshots@e31c321

MozReview-Commit-ID: HB3e5Q24afT

UltraBlame original commit: 933b30269777f718a14d2fc379e563a051b14618
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
Adds a new captureType, fullPageTruncated

Fixes upstream bug: mozilla-services/screenshots#2129
Export of commit: mozilla-services/screenshots@e31c321

MozReview-Commit-ID: HB3e5Q24afT

UltraBlame original commit: 933b30269777f718a14d2fc379e563a051b14618
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
Adds a new captureType, fullPageTruncated

Fixes upstream bug: mozilla-services/screenshots#2129
Export of commit: mozilla-services/screenshots@e31c321

MozReview-Commit-ID: HB3e5Q24afT

UltraBlame original commit: 933b30269777f718a14d2fc379e563a051b14618
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Development

No branches or pull requests

6 participants