Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

If the "Save visible" and "Save full page" buttons are clicked multiple times, a new tab is opened for each click #1799

Closed
SoftVision-CosminMuntean opened this issue Oct 20, 2016 · 1 comment
Assignees
Milestone

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 49.0.1
  • Mozilla Page Shot 0.1.201610172213

[Affected Platforms]:

  • All Windows
  • All Mac

[Prerequisites]:

  • Latest Page Shot add-on (v0.1.201610172213) is installed on a clean profile.

[Steps to reproduce]:
1 Open the browser with the profile from prerequisite and navigate to any web page.
2. Click on the "Page Shot" button from browser toolbar.
3. Click multiple times on the "Save visible" or "Save full page" buttons.
4. Navigate through the newly opened tabs.

[Expected result]:

  • Only one tab is opened even if the button is clicked multiple times.

[Actual result]:

  • A new tab is opened for each click and on some tabs the captured image is broken.

[Additional Notes]:

@ianb ianb modified the milestones: Stretch, Cygnus X-1 Nov 2, 2016
@ianb ianb self-assigned this Nov 10, 2016
@fzzzy fzzzy closed this as completed in fafef59 Nov 15, 2016
@SoftVision-CosminMuntean
Copy link
Author

It seems that this issue is reproducible on the latest Firefox Screenshots (5.2.3356) version for the "Save visible" and "Save full page" buttons.
Here is a screen recording with the issue: https://goo.gl/vGB7oF.

jaredhirsch added a commit that referenced this issue Mar 27, 2017
Fix #1799, don't allow taking a shot twice by quickly clicking a button
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants