trim leading slash before uploading chains to S3 #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhodges
force-pushed
the
remove-leading-slash
branch
from
65ad3f3
to
ea5f0b5
Compare
jmhodges
force-pushed
the
remove-leading-slash
branch
from
ea5f0b5
to
d930169
Compare
The stage environment went down for a while. The details of why can be found in AUT-231. One of the triggers was that aws-go-sdk-v2 no longer removes leading slashes from uploaded S3 key names like the v1 version of the library did. That caused some cascading failures leading to too many AWS CloudHSM slots being consumed. This change trims the leading slashes from the uploaded S3 key names for the contentsignaturepki certificate chains. This change also gets us closer to not needing to be careful about remembering to end chainUploadLocation strings with a slash with an application of `path.Join`. The `file://` handling elsewhere is still bugged and so are the places where we do `X5U + chainName`. Updates AUT-233 Updates AUT-231
jmhodges
force-pushed
the
remove-leading-slash
branch
from
d930169
to
7c2b3a1
Compare
jbuck
approved these changes
Sep 4, 2024
alexcottner
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stage environment went down for a while. The details of why can be
found in AUT-231.
One of the triggers was that aws-go-sdk-v2 no longer removes leading
slashes from uploaded S3 key names like the v1 version of the library
did. That caused some cascading failures leading to too many AWS
CloudHSM slots being consumed.
This change trims the leading slashes from the uploaded S3 key names for
the contentsignaturepki certificate chains.
This change also gets us closer to not needing to be careful about
remembering to end chainUploadLocation strings with a slash with an
application of
path.Join. Thefile://handling elsewhere is stillbugged and so are the places where we do
X5U + chainName.Updates AUT-233
Updates AUT-231