Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This patch cleans up some stragglers in the CircleCI config that were still running on 1.19. We also change `go.mod` to include the patch portion of the Go version. Including `x.y.z`, not just `x.y` is what the Go 1.22 tooling (and, I believe 1.21) does and expects. If we don't include the patch version, various third party tools like GitHub's CodeQL can break (see github/codeql#15647 for the last time I ran into this). This version change is actually what clued me into the CircleCI version bumps that were missing as changing it broke other our CircleCI jobs. ALong the way, we also have to install go 1.22 into the separate linting job in CircleCI. We coudln't use the CircleCI go 1.22 image because it couldn't `apt-get update` successfully (something about `partial` not being right). We then had to use the `BASH_ENV` hack in there to set the `PATH` correctly. The `golang-1.22` dpkg doesn't add its `go` to the `PATH`, so we need to adjust `PATH` ourselves. And then we have to use that specific BASH_ENV hack, because CircleCI's `environment` directives doesn't know what the value of `PATH` is, so attempting something like `environment: "${PATH}:/usr/lib/go-1.22/bin"` gets you a `PATH` with only the Go 1.22 binaries. I've made AUT-158 to consolidate our go linting stuff and avoid some of these problems. Some (not all) of the rationale for AUT-158 will be mooted by a move to GitHub Actions. Along the way, I also ran `go mod tidy` which correctly noted that the the google/uuid dep is now a direct dep. Hilariously, this is the change I did first.
- Loading branch information
