Bookmarks should open in existing tab when navigating to bookmarks UI from a page #13336

yoasif · 2020-08-06T06:59:07Z

What is the user problem or growth opportunity you want to see solved?

Fennec migration, ease of use, user expectation, competitiveness.

How do you know that this problem exists today? Why is this important?

Existing behavior in Fennec. People asking for it: https://www.reddit.com/r/firefox/comments/i4kmyz/firefox_android_opening_sites_from_bookmarks/

Previously requested: #10837 #10645

"Don't make me think" and a time saver.

Existing behavior in Chrome (where most new users will be switching from) and Firefox desktop.

Who will benefit from it?

People who are directly navigating from existing pages to bookmarks no longer have to clean up their old tabs; anyone who is used to the behavior in other Android browsers.

┆Issue is synchronized with this Jira Task

yoasif · 2020-08-06T17:31:30Z

@cadeyrn the best I could find is #3551 but that doesn't really capture the use case of opening a bookmarks when starting navigating from an existing tab, which is what my issue is about. I think that this is worth discussing.

yoasif · 2020-08-06T18:19:12Z

I think this merits another look, especially since that use case is not called out in any design documentation or stories that I have access to. The best I can find with that continues to be #3551, and there has not been any discussion since then.

person808 · 2020-08-06T23:07:07Z

This appears to be the reason for the current behavior: #1012 (comment)

yoasif · 2020-08-06T23:09:31Z

@person808 Thanks for looking into that. Today, Library no longer exists, so I think this is still worth another look. 😄

binocry · 2020-08-07T07:48:02Z

so strange when on bookmark page 3 dot menu you can select "open to new tab" so what the point open bookmark to another tab as default?

haltbarmilch · 2020-08-24T20:50:14Z

The current behavior is not good for me. It would be great if i click on a bookmark it opens in the same tab, like other browsers.

hotrodwinston · 2020-09-07T19:48:23Z

The current behavior is not good for me. It would be great if i click on a bookmark it opens in the same tab, like other browsers.

Exactly this. Opening in a new tab by default without a way to change the behavior is going to drive people to other browsers - most of them chromium based making the web less open. At least give us an option.

sonora · 2020-09-09T20:15:42Z

It also leads to secondary actions, more code, and complications: We now talk about automatically closing tabs in the background after a certain time, something which carries the risk of introducing even more in omprehensible behavior. And it was triggered by users working a lot with bookmarks and thus uncontrollably and mostly involuntarily opening large numbers of tabs...

gtg947h · 2020-09-10T12:53:13Z

Every other browser opens bookmarks in the same/existing tab. Why does this need to be different? 90% of my browsing is from bookmarks and between this problem and having to choose close from the menu I spend way too much time clearing out old tabs.

gtg947h · 2020-09-18T01:53:18Z

Every other browser opens bookmarks in the same/existing tab. Why does this need to be different? 90% of my browsing is from bookmarks and between this problem and having to choose close from the menu I spend way too much time clearing out old tabs.

This behavior is annoying me more and more... A 10 minute browsing session and I have 9 different tabs open; none of them were deliberately opened as new tabs. What gives?

Between this and #5865, I find myself purging tabs every few minutes and it's really driving me nuts. Yes, my desktop browser is set to do this, but that's almost an entirely different animal.

haltbarmilch · 2020-09-18T06:17:11Z

Every other browser opens bookmarks in the same/existing tab. Why does this need to be different? 90% of my browsing is from bookmarks and between this problem and having to choose close from the menu I spend way too much time clearing out old tabs.

This behavior is annoying me more and more... A 10 minute browsing session and I have 9 different tabs open; none of them were deliberately opened as new tabs. What gives?

Between this and #5865, I find myself purging tabs every few minutes and it's really driving me nuts. Yes, my desktop browser is set to do this, but that's almost an entirely different animal.

You speack from my heart. ;-)

Diapolo · 2020-09-23T10:12:00Z

Every other browser opens bookmarks in the same/existing tab. Why does this need to be different? 90% of my browsing is from bookmarks and between this problem and having to choose close from the menu I spend way too much time clearing out old tabs.

This behavior is annoying me more and more... A 10 minute browsing session and I have 9 different tabs open; none of them were deliberately opened as new tabs. What gives?

Between this and #5865, I find myself purging tabs every few minutes and it's really driving me nuts. Yes, my desktop browser is set to do this, but that's almost an entirely different animal.

You are getting the point here, it feels EXTREMELY weird using the "new" Firefox for Android, that I consinder not using it anymore. Why did the devs chose such an ugly and nonsene behaviour at all? It's also weird that clicking into the addressbar doesn't allow to anyhow select my favorites? WHO did "invent" this? Yes that is an inproductive rant, but it's also a pitty that Mozilla destroys it's user base by intention (as it seems).

This needs to be fixed, changed, looked at.

This reverts commit e73deb2.

This reverts commit e73deb2. (cherry picked from commit d1c0e9b)

This reverts commit e73deb2. (cherry picked from commit d1c0e9b) Co-authored-by: Roger Yang <royang@mozilla.com>

czlucius · 2022-02-23T05:12:40Z

Oh no, we finally made it and now this :( Can't the behavior be fixed instead of directly falling back to reverting this change?

It seems like opening in the current tab is more problematic than opening in a new tab, given Fenix's current state. I think reverting the change will be better for Firefox Fenix, so users would not be confused, and there'll be more time to investigate the issue before rolling out to end users.

To the Fenix devs (rocketsroger & jonalmeida), sorry for troubling you in this fix.

maverick74 · 2022-02-23T10:09:43Z

@rocketsroger can you please also work on the pinned bookmarks on the home tab

Improve home screen logic, always associate Home screen with an actual tab(#20012 (comment))

They apparently share a lot...

Cheap-Skate · 2022-02-23T10:56:52Z

@czlucius thanks for all your hard work. I think it will bring benefits because it highlights how broken Fenix is at the moment. All other browsers give a simple choice to open in a new or existing tab. But Fenix does not, it is hardwired to open everything in a new tab.

Hopefully devs will take notice (I expect they already are). But I think fixing Fenix properly will be quite complicated.

czlucius · 2022-02-23T10:58:21Z

because it highlights how broken Fenix is at the moment.

Just to clarify, I don't view Fenix as broken.

…mode is not private or previous fragment is not home

…ivate or previous fragment is not home

rocketsroger · 2022-02-24T03:25:10Z

Thanks for reopening and tagging for me 👍

SoftVision-LorandJanos · 2022-02-24T07:48:42Z

Verified as fixed on the latest Nightly build 99.0a1 (2022-02-24).
Device used: Oppo Reno 6 (Android 11).
Closing the ticket as fixed.

…le#23169) * For mozilla-mobile#13336: Open bookmarks in current tab * For mozilla-mobile#13336: Fix tests to verify bookmark opening in current tab * Change test name for handleBookmarkTapped

…lla-mobile#23169)" This reverts commit e73deb2.

…mode is not private or previous fragment is not home

r6squeegee · 2022-05-24T07:57:55Z

I don't think this is fixed, 23946 only fixes this if you manually click on "settings" icon then "bookmarks" then click on a bookmark.

The scenario of bookmarks showing on the home page, doesn't work. This is my most common flow :

I'm on a web page, and done with it
I click on the url field to bring up the home screen so I can see my book marks (1 click on a big bar, adverse to 2 clicks for going to settings (small icon) then bookmarks (on a popup menu))
I click on the next bookmark

That use to open the new page in the existing tab, it doesn't anymore. If I go through that routine with 8 bookmarks I end up with 8 tabs.

rocketsroger · 2022-05-24T15:16:07Z

I don't think this is fixed, 23946 only fixes this if you manually click on "settings" icon then "bookmarks" then click on a bookmark.

Created an issue to track this specific workflow. #25362. Thanks

Obscerno · 2022-05-24T15:44:09Z

Thanks for your work on this @rocketsroger! If you can make this fix, we'll be one step closer to untangling the homepage.

And if you want to go down this rabbit hole, this comment lists some of the other strange behaviour on the homepage: #20012 (comment)

rocketsroger · 2022-05-24T15:59:27Z

And if you want to go down this rabbit hole, this comment lists some of the other strange behaviour on the homepage: #20012 (comment)

Looks like an issue was opened by the contributor. That said, it sounds very similar to the issue you have here with bookmarks on homepage.

plwt · 2022-08-24T20:03:54Z

User feedback - https://support.mozilla.org/en-US/questions/1387083

maverick74 · 2022-10-12T14:48:21Z

Vote about how home opens bookmarks (new tab vs current tab) ongoing at:

https://connect.mozilla.org/t5/ideas/on-firefox-mobile-make-home-page-links-open-in-current-tab/idi-p/15672

github-actions bot added the needs:triage Issue needs triage label Aug 6, 2020

person808 added Feature:Bookmarks needs:triage Issue needs triage and removed needs:triage Issue needs triage labels Aug 6, 2020

liuche added feature request 🌟 New functionality and improvements and removed needs:triage Issue needs triage labels Aug 10, 2020

data-sync-user changed the title ~~Bookmarks should open in existing tab when navigating to bookmarks UI from a page~~ FNX2-18763 ⁃ Bookmarks should open in existing tab when navigating to bookmarks UI from a page Aug 10, 2020

data-sync-user changed the title ~~FNX2-18763 ⁃ Bookmarks should open in existing tab when navigating to bookmarks UI from a page~~ FNX3-23036 ⁃ Bookmarks should open in existing tab when navigating to bookmarks UI from a page Aug 11, 2020

data-sync-user changed the title ~~FNX3-23036 ⁃ Bookmarks should open in existing tab when navigating to bookmarks UI from a page~~ FNX-14517 ⁃ Bookmarks should open in existing tab when navigating to bookmarks UI from a page Aug 11, 2020

s-ankur mentioned this issue Aug 19, 2020

Add option in Settings to disable the opening of bookmark in a new tab, instead of the selected one #13920

Closed

s-ankur mentioned this issue Aug 26, 2020

Open bookmarks in current tab #14220

Closed

yoasif mentioned this issue Sep 9, 2020

[Telemetry] Opening a new tab from saved data #14866

Closed

7 tasks

cadeyrn mentioned this issue Sep 23, 2020

Option to reuse tabs #15341

Closed

kbrosnan added the Feature:FennecTransition label Sep 24, 2020

htsmi mentioned this issue Oct 21, 2020

[Bug] Inconsistent back button behaviour when navigating to library from browser #5727

Closed

ekager mentioned this issue Nov 10, 2020

Homescreen elements should be be interactable when keyboard is up #16351

Closed

mergify bot pushed a commit that referenced this issue Feb 23, 2022

Revert "For #13336: Open bookmarks in current tab (#23169)"

d1c0e9b

This reverts commit e73deb2.

mergify bot pushed a commit that referenced this issue Feb 23, 2022

Revert "For #13336: Open bookmarks in current tab (#23169)"

b45adf2

This reverts commit e73deb2. (cherry picked from commit d1c0e9b)

rocketsroger added a commit that referenced this issue Feb 23, 2022

Revert "For #13336: Open bookmarks in current tab (#23169)" (#23914)

690c94f

This reverts commit e73deb2. (cherry picked from commit d1c0e9b) Co-authored-by: Roger Yang <royang@mozilla.com>

rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 23, 2022

Close mozilla-mobile#13336: Open bookmark in current tab if browsing …

31f4234

…mode is not private or previous fragment is not home

gabrielluong added this to the 99 milestone Feb 23, 2022

gabrielluong mentioned this issue Feb 23, 2022

Close #13336: Open bookmark in current tab if browsing mode is not private or previous fragment is not home #23946

Merged

3 tasks

mergify bot closed this as completed in #23946 Feb 24, 2022

mergify bot pushed a commit that referenced this issue Feb 24, 2022

Close #13336: Open bookmark in current tab if browsing mode is not pr…

77c2ad9

…ivate or previous fragment is not home

gabrielluong reopened this Feb 24, 2022

gabrielluong added the eng:qa:needed QA Needed label Feb 24, 2022

SoftVision-LorandJanos closed this as completed Feb 24, 2022

SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 24, 2022

pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022

Revert "For mozilla-mobile#13336: Open bookmarks in current tab (mozi…

a177f7f

…lla-mobile#23169)" This reverts commit e73deb2.

pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022

Close mozilla-mobile#13336: Open bookmark in current tab if browsing …

9cbe978

…mode is not private or previous fragment is not home

data-sync-user changed the title ~~FNX-14517 ⁃ Bookmarks should open in existing tab when navigating to bookmarks UI from a page~~ Bookmarks should open in existing tab when navigating to bookmarks UI from a page May 19, 2022

czlucius mentioned this issue Jun 18, 2022

regression in v100: bookmarks should open into a new tab #25599

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bookmarks should open in existing tab when navigating to bookmarks UI from a page #13336

Bookmarks should open in existing tab when navigating to bookmarks UI from a page #13336

yoasif commented Aug 6, 2020 •

edited by data-sync-user

Loading

yoasif commented Aug 6, 2020

yoasif commented Aug 6, 2020

person808 commented Aug 6, 2020

yoasif commented Aug 6, 2020

binocry commented Aug 7, 2020 •

edited

Loading

haltbarmilch commented Aug 24, 2020

hotrodwinston commented Sep 7, 2020

sonora commented Sep 9, 2020

gtg947h commented Sep 10, 2020

gtg947h commented Sep 18, 2020

haltbarmilch commented Sep 18, 2020

Diapolo commented Sep 23, 2020 •

edited

Loading

czlucius commented Feb 23, 2022 •

edited

Loading

maverick74 commented Feb 23, 2022

Cheap-Skate commented Feb 23, 2022

czlucius commented Feb 23, 2022

rocketsroger commented Feb 24, 2022

SoftVision-LorandJanos commented Feb 24, 2022

r6squeegee commented May 24, 2022 •

edited

Loading

rocketsroger commented May 24, 2022

Obscerno commented May 24, 2022

rocketsroger commented May 24, 2022

plwt commented Aug 24, 2022

maverick74 commented Oct 12, 2022

Bookmarks should open in existing tab when navigating to bookmarks UI from a page #13336

Bookmarks should open in existing tab when navigating to bookmarks UI from a page #13336

Comments

yoasif commented Aug 6, 2020 • edited by data-sync-user Loading

What is the user problem or growth opportunity you want to see solved?

How do you know that this problem exists today? Why is this important?

Who will benefit from it?

yoasif commented Aug 6, 2020

yoasif commented Aug 6, 2020

person808 commented Aug 6, 2020

yoasif commented Aug 6, 2020

binocry commented Aug 7, 2020 • edited Loading

haltbarmilch commented Aug 24, 2020

hotrodwinston commented Sep 7, 2020

sonora commented Sep 9, 2020

gtg947h commented Sep 10, 2020

gtg947h commented Sep 18, 2020

haltbarmilch commented Sep 18, 2020

Diapolo commented Sep 23, 2020 • edited Loading

czlucius commented Feb 23, 2022 • edited Loading

maverick74 commented Feb 23, 2022

Cheap-Skate commented Feb 23, 2022

czlucius commented Feb 23, 2022

rocketsroger commented Feb 24, 2022

SoftVision-LorandJanos commented Feb 24, 2022

r6squeegee commented May 24, 2022 • edited Loading

rocketsroger commented May 24, 2022

Obscerno commented May 24, 2022

rocketsroger commented May 24, 2022

plwt commented Aug 24, 2022

maverick74 commented Oct 12, 2022

yoasif commented Aug 6, 2020 •

edited by data-sync-user

Loading

binocry commented Aug 7, 2020 •

edited

Loading

Diapolo commented Sep 23, 2020 •

edited

Loading

czlucius commented Feb 23, 2022 •

edited

Loading

r6squeegee commented May 24, 2022 •

edited

Loading