Sync with MoveIt #834
Merged
Sync with MoveIt #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression of 93c3f63 Closes: moveit#2804
This was a workaround for catkin/catkin_tools#594, which is no longer needed because python3-catkin-tools 0.7 added the required dependency.
Because std::make_pair uses the decayed type (std::string), the strings were actually copied into a temporary, which was subsequently referenced by the elements of std::pair, leading to a stack-use-after-scope error. Explicitly passing const references into std::make_pair via std::cref() resolves the issue mentioned in #2809.
We need to pass the current PlanningScene down to the actual collision checking methods
* fix getting wrong type ID * update unit test
…t#2833) If the MP plugin was created in a non-rviz context (e.g. directly via librviz), there might be no window manager and thus no parent widget available for panels.
This commit makes the trajectory visualization topic relative. This was done to make sure that it respects the namespaces that are set in launch files. Co-authored-by: Felix von Drigalski <FvDrigalski@gmail.com> Co-authored-by: Michael Görner <me@v4hn.de>
- Remove convertToRobotTrajectory() and integrate its line of code into setSuccessResponse() - Pass the final start_state into setSuccessResponse() Co-authored-by: Cristian Beltran <cristianbehe@gmail.com> Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
JafarAbdi
approved these changes
Nov 29, 2021
|
This may cause conflicts with #452, not sure which one we want to merge first |
tylerjw
reviewed
Nov 29, 2021
There was a problem hiding this comment.
This has a bunch of Pilz planner changes. @henningkayser should look over this to make sure these changes are in line with what he's changed in his Pilz port.
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
- Coverage 56.68% 56.67% -0.01%
==========================================
Files 200 200
Lines 21660 21660
==========================================
- Hits 12276 12273 -3
- Misses 9384 9387 +3
Continue to review full report at Codecov.
|
henningkayser
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Synced the following commits from MoveIt